Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Use npm install when running Greenkeeper #74

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

cmfcmf
Copy link
Contributor

@cmfcmf cmfcmf commented Dec 2, 2018

Greenkeeper incorrectly assumes upgrading a dependency failed in #73 (comment). This is because we use npm ci to install dependencies on Travis, see here: greenkeeperio/greenkeeper-lockfile#156

This PR conditionally uses npm install when building a Greenkeeper branch and should fix #73.

@cmfcmf cmfcmf requested a review from janrenz December 2, 2018 22:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 118

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.129%

Totals Coverage Status
Change from base Build 114: 0.0%
Covered Lines: 300
Relevant Lines: 304

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 118

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.129%

Totals Coverage Status
Change from base Build 114: 0.0%
Covered Lines: 300
Relevant Lines: 304

💛 - Coveralls

@janrenz janrenz merged commit 582d62c into master Dec 4, 2018
@janrenz janrenz deleted the fix-greenkeeper branch December 4, 2018 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An in-range update of amqplib is breaking the build 🚨
4 participants