Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏ enhanced readability by formatting date strings #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✏ enhanced readability by formatting date strings #34

wants to merge 1 commit into from

Conversation

ayangupta9
Copy link

Issue Description

'Released On' and 'Aired On' dates were formatted in DD/MM/YYYY format

Changes

  • Reformated date format into readable to provide better User Experience by creating formatDate function in formatDate.js

Screenshots

BEFORE

before_01
before_02

AFTER

after_01
after_02

@ayangupta9 ayangupta9 mentioned this pull request Sep 3, 2021
Closed
bikkimahato
bikkimahato reviewed Sep 13, 2021
View reviewed changes
js/indexMovies.js
'https://api.themoviedb.org/3/discover/movie?api_key=ca5d667528ca51e527d9e4f7830d97d2&language=en-US&sort_by=popularity.desc&include_adult=false'
)
.then(response => {
let movies = response.data.results
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add checks to see if results exists or is defined then only the code should proceed further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bikkimahato bikkimahato bikkimahato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayangupta9 @bikkimahato