Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTCONDOR-2262 use-new-router-syntax #596

Merged
merged 1 commit into from
May 6, 2024

Conversation

JaimeFrey
Copy link
Member

Old syntax is kept, commented out with text about how to enable it.

Old syntax is kept, commented out with text about how to enable it.
@ColeBollig
Copy link
Contributor

Chatted with @JaimeFrey, and we decided we should hold off on merging this change to discussion timelines with @brianhlin and/or @timtheisen because current CEs are running with V23 LTS condor and the change where this is relevant is in the V23 feature series. Could possibly cause confusion if changed now. Keep in mind the condor_upgrade_check script (forget the CE wrapper version) checks for the future Job Router syntax gotcha.

@timtheisen timtheisen marked this pull request as draft March 6, 2024 17:00
@timtheisen
Copy link
Member

We will apply this for 24.0

@timtheisen timtheisen changed the base branch from V23-branch to V23_x-branch April 12, 2024 19:35
@timtheisen timtheisen marked this pull request as ready for review April 12, 2024 19:36
@timtheisen
Copy link
Member

Once this is reviewed, we will release a HTCondor-CE 23.x version that matches the current HTCondor 23.x feature version.

Copy link
Contributor

@ColeBollig ColeBollig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaimeFrey JaimeFrey merged commit abfaf82 into V23_x-branch May 6, 2024
36 checks passed
@JaimeFrey JaimeFrey deleted the V23-HTCONDOR-2262-use-new-router-syntax branch May 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants