Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module5-task1 #8

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Module5-task1 #8

wants to merge 10 commits into from

Conversation

ElenaLisavina
Copy link
Contributor

Task5

Director099
Director099 reviewed Dec 10, 2024
View reviewed changes
Copy link

@Director099 Director099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Осталось

  1. Добавить декоротивное изображние https://s.mail.ru/apg4/dVwXjrPSX
  2. соц сети добавить https://s.mail.ru/JX8d/NQfxYQPcC

source/index.html Show resolved Hide resolved
source/index.html Outdated
<picture>
<source width="70" height="59" type="image/svg+xml" media="(min-width: 1440px)" srcset="images/svg/logotype-desktop.svg">
<source width="60" height="50" type="image/svg+xml" media="(min-width: 768px)" srcset="images/svg/logotype-tablet.svg">
<img class="logotype__pictore" src="images/svg/logotype.svg" width="33" height="38" alt="Логотип CAT ENERGY">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logotype.svg - такого файла нет, ты видимо хотела использовать logo-mobile.svg

source/index.html
</picture>
<picture>
<source width="560" height="512" type="image/png" media="(min-width: 768px)" srcset="images/raster/[email protected] 1x, images/raster/[email protected] 2x">
<img class="slider__image" src="images/raster/[email protected]" srcset="images/[email protected] 2x" width="280" height="256" alt="Фото после: худенький котик">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srcset="images/[email protected] 2x" - путь до картинки не верный
Правильно так: srcset="images/raster/[email protected] 2x" папку raster забыла добавить

source/index.html Outdated

<div class="page-footer__wrapper">
<a class="page-footer__logotype logotype" href="index.html">
<img class="logotype__name" src="images/logotype-name.svg/" width="128" height="24" alt="Cat Energy">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src="images/logotype-name.svg/" - путь не верный

Првильно: src="images/svg/logotype-name.svg" папку СВГ забыла

source/icons/black-cat..svg Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Ивнование файла, на конце лишняя точка
  2. У тебя СВГ не верно экспортировано, замени содержимое на это
<svg width="36" height="50" viewBox="0 0 36 50" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M28.2034 0H28.008C27.6778 0.187081 27.415 0.473924 27.2571 0.819588C26.968 1.37738 26.7453 1.96735 26.5937 2.57732C26.5612 2.76073 26.4688 2.92811 26.331 3.05315C26.1932 3.17818 26.0179 3.25377 25.8326 3.26804C25.2658 3.36597 24.7288 3.59243 24.2626 3.93012C23.7965 4.26781 23.4135 4.7078 23.1429 5.21649C22.7708 5.87697 22.4526 6.5665 22.1914 7.27835C21.4611 9.17526 20.9006 11.134 20.2114 13.0464C19.8874 13.9175 19.872 13.9175 18.8949 13.9175C17.7274 13.9175 17.8097 13.7371 17.7943 15.0258C17.7943 15.433 17.9177 15.6392 18.3497 15.6186C18.4834 15.6186 18.684 15.5515 18.7354 15.7268C18.7869 15.9021 18.612 15.9794 18.5091 16.0825C17.8994 16.7029 17.1276 17.1388 16.2823 17.3402C15.3051 17.6031 14.3074 17.8093 13.356 18.1289C10.9131 18.9485 8.65543 20.0928 6.89657 22.0309C5.86814 23.2347 5.04455 24.6001 4.45886 26.0722C2.57143 30.5258 1.656 35.2165 0.946286 39.9536C0.612 42.1753 0.375429 44.4072 0.195429 46.6546C0.102857 47.7577 0 48.8763 0 50H17.1411C17.1696 49.7731 17.1283 49.5429 17.0229 49.3402C16.858 48.9289 16.5901 48.5672 16.2451 48.29C15.9 48.0128 15.4895 47.8295 15.0531 47.7577C14.6931 47.6753 14.652 47.567 14.8731 47.2835C15.2338 46.801 15.5103 46.2607 15.6909 45.6856C16.5291 43.2062 16.8531 40.6186 17.2594 38.0567C17.4889 36.0999 18.0894 34.2051 19.0286 32.4742C19.7611 31.2002 20.7382 30.0842 21.9034 29.1907C22.3303 28.866 22.3457 28.866 22.4177 29.4175C22.4691 29.7835 22.4794 30.1598 22.5051 30.5309C22.6595 32.9662 22.6285 35.4097 22.4126 37.8402C22.2184 39.7242 22.1926 41.6217 22.3354 43.5103C22.5399 45.7029 22.9304 47.8739 23.5029 50H30.3429C30.2536 49.442 29.9973 48.9243 29.6078 48.5156C29.2184 48.1069 28.7143 47.8264 28.1623 47.7113C27.5177 47.6087 26.8587 47.6438 26.2286 47.8144C25.92 47.8866 25.7914 47.8144 25.7657 47.4794C25.5529 44.7505 25.7261 42.0051 26.28 39.3247C26.966 36.2304 27.4912 33.1025 27.8537 29.9536C27.9887 28.6819 28.3881 27.4528 29.0263 26.3454C29.6383 25.2526 30.1731 24.1186 30.7749 23.0206C31.0138 22.6214 31.1575 22.1723 31.195 21.7083C31.2325 21.2443 31.1626 20.7779 30.9909 20.3454C30.852 19.9794 30.7183 19.6082 30.5486 19.2577C30.0343 18.2526 29.52 17.2577 29.0469 16.2423C28.7949 15.7268 28.8514 15.6649 29.412 15.6495C30.2503 15.6495 30.2503 15.6495 30.2657 14.8041C30.2657 14.6907 30.2657 14.5773 30.2657 14.4639C30.2657 14.1082 30.132 13.9124 29.7514 13.9485C29.4943 13.9485 29.2371 13.9485 28.9697 13.9485C28.6149 13.9485 28.512 13.799 28.5994 13.433C28.7729 12.838 29.1142 12.306 29.5823 11.9009C30.0503 11.4958 30.6252 11.2349 31.2377 11.1495C32.3772 11.0505 33.5251 11.1252 34.6423 11.3711C34.7712 11.4118 34.9109 11.4001 35.0312 11.3383C35.1515 11.2766 35.2427 11.1699 35.2851 11.0412C35.4909 10.5258 35.7171 10.0103 35.9486 9.49484C36.001 9.40339 36.0242 9.29801 36.015 9.19293C36.0058 9.08785 35.9647 8.98812 35.8971 8.90722C34.2514 6.81443 32.4669 4.86082 30.0343 3.60825C29.9168 3.55754 29.8138 3.47814 29.7347 3.3773C29.6557 3.27646 29.6031 3.15738 29.5817 3.03093C29.444 2.29408 29.225 1.57487 28.9286 0.886598C28.7895 0.519904 28.5349 0.20865 28.2034 0V0Z" fill="black"/>
</svg>

source/styles/blocks/logotype.scss Outdated
Comment on lines 2 to 6
position: absolute;
left: 50%;
top: 50%;
transform: translate(-50%, -50%);
fill: #111111;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. fill работает ТОЛЬКО для тега СВГ, потому можно удалить
  2. позиционирование тут лишнее, потому можно смело удлаить

source/styles/blocks/logotype.scss Outdated

@media (min-width: $tablet-width) {
position: relative;
transform: translate(0);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже лишнее можно удалить

source/styles/blocks/example.scss Outdated
Comment on lines 7 to 9
position: absolute;
top: 1700px;
left: -2px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. тебе нужно позиционировать относительно блока slider потому добавь
    .slider { position: relative }
  2. нужно выровнить по середине
    position: absolute;
    top: 0;
    left: 50%; 
    transform: translateX(-50%);

source/styles/blocks/example.scss Outdated
Comment on lines 14 to 38
.slider__button::before {
content: "";
width: 40px;
height: 40px;
background-color: $white;
border-radius: 50%;
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%);
border: 2px solid $dark-grey;
}

.slider__button::after {
content: "";
width: 24px;
height: 18px;
background-color: $white;
border-radius: 50%;
position: absolute;
top: 53%;
left: 53%;
transform: translate(-50%, -50%);
background-image: url("../../icons/stack.svg#slider-button");
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

советую экспорнтировать https://s.mail.ru/LcGk/MLv46FRXt сразу весь квадрат так тебе будет проще

source/index.html Outdated
</li>
</ul>
</nav>
</header>/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишний слеш на конце, удали пожалуйста, а то в верстке отображается https://s.mail.ru/6txd/1L3rfEkrY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Director099 Director099 Director099 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElenaLisavina @Director099