Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Отрисуй меня полностью #7

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

harl-i
Copy link
Contributor

@harl-i harl-i commented Dec 19, 2024

js/functions.js Outdated
// function checkMeetingTimeframe (startWorkingDay, endWorkingDay, beginningMeeting, durationMeeting) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удали файл function.js. Он больше не нужен, критерий Б12

@@ -1,6 +1,8 @@
import {getRandomPhotoObjects} from './photos.js';
import {showThumbnail} from './thumbnails.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь прекрасно все

js/thumbnails.js Outdated
@@ -0,0 +1,21 @@
const thumbnailTemplate = document.querySelector('#picture').content.querySelector('.picture');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нейминг. Критерий Д6

@keksobot keksobot changed the title Добавляет решение задачи "Отрисуй меня полностью" Отрисуй меня полностью Dec 19, 2024
@keksobot keksobot merged commit caa4afd into htmlacademy-javascript:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants