Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace/warehouse_app): add resource to manage warehouse application #5856

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add a new resource used to add application to Workspace app warehouse.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource to manage application.
2. add related document, environmentvariable and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o workspace -f TestAccAppWarehouseApp_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccAppWarehouseApp_basic -timeout 360m -parallel 10
=== RUN   TestAccAppWarehouseApp_basic
=== PAUSE TestAccAppWarehouseApp_basic
=== CONT  TestAccAppWarehouseApp_basic
--- PASS: TestAccAppWarehouseApp_basic (34.29s)
PASS
coverage: 5.2% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 34.487s coverage: 5.2% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong changed the title feat(workspace/warehouse_app): add resource to manage warehouse app feat(workspace/warehouse_app): add resource to manage warehouse application Nov 14, 2024
@wuzhuanhong wuzhuanhong force-pushed the app_repo branch 2 times, most recently from 14ff36d to abc5287 Compare November 15, 2024 06:44

# huaweicloud_workspace_app_warehouse_app

Use this resource to add a application to Workspace APP warehouse within HuaweiCloud.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use this resource to add a application to Workspace APP warehouse within HuaweiCloud.
Manages an application resource of Workspace APP warehouse within HuaweiCloud.

@wuzhuanhong wuzhuanhong force-pushed the app_repo branch 2 times, most recently from 6cdeaa9 to e9bcd74 Compare November 19, 2024 06:45
@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o workspace -f TestAccAppWarehouseApp_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccAppWarehouseApp_basic -timeout 360m -parallel 10
=== RUN TestAccAppWarehouseApp_basic
=== PAUSE TestAccAppWarehouseApp_basic
=== CONT TestAccAppWarehouseApp_basic
--- PASS: TestAccAppWarehouseApp_basic (31.51s)
PASS
coverage: 5.2% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 31.582s coverage: 5.2% of statements in ./huaweicloud/services/workspace

@Lance52259
Copy link
Collaborator

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 57d61a0 into huaweicloud:master Nov 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants