Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dms): support to get and delete kafka background tasks #5870

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Nov 15, 2024

What this PR does / why we need it:
support to get and delete kafka background tasks

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/dms" TESTARGS="-run TestAccDataSourceDmsKafkaBackgroundTasks_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dms -v -run TestAccDataSourceDmsKafkaBackgroundTasks_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceDmsKafkaBackgroundTasks_basic
=== PAUSE TestAccDataSourceDmsKafkaBackgroundTasks_basic
=== CONT  TestAccDataSourceDmsKafkaBackgroundTasks_basic
--- PASS: TestAccDataSourceDmsKafkaBackgroundTasks_basic (859.30s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dms       859.354s

make testacc TEST="./huaweicloud/services/acceptance/dms" TESTARGS="-run TestAccDmsKafkaBackgroundTaskDelete_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dms -v -run TestAccDmsKafkaBackgroundTaskDelete_basic -timeout 360m -parallel 4
=== RUN   TestAccDmsKafkaBackgroundTaskDelete_basic
=== PAUSE TestAccDmsKafkaBackgroundTaskDelete_basic
=== CONT  TestAccDmsKafkaBackgroundTaskDelete_basic
--- PASS: TestAccDmsKafkaBackgroundTaskDelete_basic (868.53s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dms       868.588s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the feat(dms)_support_to_get_and_delete_kafka_background_tasks branch from 2cbd316 to 3b2d110 Compare November 15, 2024 08:06
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 15, 2024
@houpeng80
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/approve

@github-ci-robot github-ci-robot merged commit f8e0cb3 into huaweicloud:master Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants