Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dds): support to get dds quotas #5873

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat(dds): support to get dds quotas #5873

merged 1 commit into from
Nov 20, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Nov 18, 2024 •
edited
Loading

What this PR does / why we need it:
support to get dds quotas

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/dds" TESTARGS="-run  TestAccDataSourceDdsQuotas_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dds -v -run  TestAccDataSourceDdsQuotas_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceDdsQuotas_basic
=== PAUSE TestAccDataSourceDdsQuotas_basic
=== CONT  TestAccDataSourceDdsQuotas_basic
--- PASS: TestAccDataSourceDdsQuotas_basic (14.88s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dds       14.942s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_to_get_dds_quotas branch from 80f50cb to 2bab6b9 Compare November 18, 2024 03:17
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 19, 2024
@houpeng80
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
github-ci-robot
github-ci-robot approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/approve

@github-ci-robot github-ci-robot merged commit 16f7cba into huaweicloud:master Nov 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot