Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbss): add new resource to manage RDS database bind DBSS instance #5877

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

Add new resource manages add RDS database to DBSS instance.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1.support new resource manages add RDS database to DBSS instance.
2.support related document and acceptance test.

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/dbss" TESTARGS="-run TestAccAddRdsDatabase_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dbss -v -run TestAccAddRdsDatabase_basic -timeout 360m -parallel 4
=== RUN   TestAccAddRdsDatabase_basic
=== PAUSE TestAccAddRdsDatabase_basic
=== CONT  TestAccAddRdsDatabase_basic
--- PASS: TestAccAddRdsDatabase_basic (906.70s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dbss      906.756s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image
    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@ruwenqiang123 ruwenqiang123 changed the title feat(dbss): add new resource manages add RDS database to DBSS instance feat(dbss): add new resource to manage RDS database bind DBSS instance Nov 18, 2024
@ruwenqiang123 ruwenqiang123 changed the title feat(dbss): add new resource to manage RDS database bind DBSS instance feat(dbss): add new resource to manage RDS database bind DBSS instance Nov 18, 2024
@ruwenqiang123 ruwenqiang123 force-pushed the dev_rds_database branch 2 times, most recently from 71a3f58 to 46e2022 Compare November 18, 2024 11:25
docs/resources/dbss_rds_database.md Outdated Show resolved Hide resolved
docs/resources/dbss_rds_database.md Show resolved Hide resolved
docs/resources/dbss_rds_database.md Outdated Show resolved Hide resolved
@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/dbss" TESTARGS="-run TestAccAddRdsDatabase_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dbss -v -run TestAccAddRdsDatabase_basic -timeout 360m -parallel 4
=== RUN   TestAccAddRdsDatabase_basic
=== PAUSE TestAccAddRdsDatabase_basic
=== CONT  TestAccAddRdsDatabase_basic
--- PASS: TestAccAddRdsDatabase_basic (1103.92s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dbss      1103.972s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit ba78d2c into huaweicloud:master Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants