Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cph): support updating cph phone property #5895

Merged

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Nov 21, 2024

What this PR does / why we need it:
support updating cph phone property

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

support updating cph phone property

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/cph" TESTARGS="-run TestAccCphPhoneProperty_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cph -v -run TestAccCphPhoneProperty_basic -timeout 360m -parallel 4
=== RUN   TestAccCphPhoneProperty_basic
=== PAUSE TestAccCphPhoneProperty_basic
=== CONT  TestAccCphPhoneProperty_basic
--- PASS: TestAccCphPhoneProperty_basic (2011.76s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cph       2011.801s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@luoping-12345 luoping-12345 force-pushed the cph_phone_property branch 3 times, most recently from e81808a to 0b5572a Compare November 21, 2024 08:53
@github-actions github-actions bot added size/L and removed size/M labels Nov 21, 2024
@luoping-12345 luoping-12345 force-pushed the cph_phone_property branch 3 times, most recently from be7d4c6 to 2207dbe Compare November 21, 2024 09:09
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 22, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 4489c29 into huaweicloud:master Nov 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants