-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cph): support updating cph phone property #5895
Merged
github-ci-robot
merged 1 commit into
huaweicloud:master
from
luoping-12345:cph_phone_property
Nov 25, 2024
Merged
feat(cph): support updating cph phone property #5895
github-ci-robot
merged 1 commit into
huaweicloud:master
from
luoping-12345:cph_phone_property
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoping-12345
force-pushed
the
cph_phone_property
branch
3 times, most recently
from
November 21, 2024 08:53
e81808a
to
0b5572a
Compare
luoping-12345
force-pushed
the
cph_phone_property
branch
3 times, most recently
from
November 21, 2024 09:09
be7d4c6
to
2207dbe
Compare
saf3dfsa
reviewed
Nov 21, 2024
huaweicloud/services/cph/resource_huaweicloud_cph_phone_property.go
Outdated
Show resolved
Hide resolved
huaweicloud/services/cph/resource_huaweicloud_cph_phone_property.go
Outdated
Show resolved
Hide resolved
luoping-12345
force-pushed
the
cph_phone_property
branch
from
November 21, 2024 09:30
2207dbe
to
41d8617
Compare
houpeng80
reviewed
Nov 22, 2024
huaweicloud/services/cph/resource_huaweicloud_cph_phone_property.go
Outdated
Show resolved
Hide resolved
huaweicloud/services/cph/resource_huaweicloud_cph_phone_property.go
Outdated
Show resolved
Hide resolved
luoping-12345
force-pushed
the
cph_phone_property
branch
from
November 22, 2024 01:21
41d8617
to
e1066a9
Compare
saf3dfsa
reviewed
Nov 22, 2024
luoping-12345
force-pushed
the
cph_phone_property
branch
from
November 22, 2024 02:10
e1066a9
to
6c9ca32
Compare
/lgtm |
/approve |
github-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 25, 2024
github-ci-robot
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been approved by: @Jason-Zhang9309
/approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
support updating cph phone property
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<