Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbss): add a new datasource to get the list of RDS databases #5903

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

Add a new datasource to get the list of RDS databases.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1.support a new datasource to get the list of RDS databases.
2.support related document and acceptance test.

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/dbss" TESTARGS="-run TestAccDataSourceRdsDatabases_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dbss -v -run TestAccDataSourceRdsDatabases_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceRdsDatabases_basic
=== PAUSE TestAccDataSourceRdsDatabases_basic
=== CONT  TestAccDataSourceRdsDatabases_basic
--- PASS: TestAccDataSourceRdsDatabases_basic (510.53s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dbss      510.620s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 27, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit d3f3e69 into huaweicloud:master Nov 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants