Debug margin #107
Merged
Debug margin #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumos42
approved these changes
Sep 4, 2023
atvanguard
added a commit
that referenced
this pull request
Sep 4, 2023
* remove debug logs * Fix snapshot saving error * Snapshot fix: save snapshot at blockNumber - 1 * Add blockNumber in logs * assert isValidator when assertLowMargin * Fix snapshot bug * Debug margin (#107) * Fix GetAvailableMargin * v5activation --------- Co-authored-by: Shubham Goyal <[email protected]> * logs --------- Co-authored-by: Shubham Goyal <[email protected]>
atvanguard
added a commit
that referenced
this pull request
Sep 30, 2023
* remove debug logs * Fix snapshot saving error * Snapshot fix: save snapshot at blockNumber - 1 * Add blockNumber in logs * assert isValidator when assertLowMargin * Fix snapshot bug * Debug margin (#107) * Fix GetAvailableMargin * v5activation --------- Co-authored-by: Shubham Goyal <[email protected]> * logs --------- Co-authored-by: Shubham Goyal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented