Match orders in same block as they are placed #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atvanguard @debaghtk please help with naming on new structs, files and functions |
debaghtk
reviewed
Apr 2, 2024
.avalanche-cli.json
Outdated
| } | ||
| } | ||
| }, | ||
| "singlenodeenabled": false |
There was a problem hiding this comment.
[nit] needs hyphenation like other values
There was a problem hiding this comment.
this name is interpreter by avalanche cli, we can't control it
debaghtk
reviewed
Apr 2, 2024
miner/orderbook_checker.go
Outdated
| "github.com/ethereum/go-ethereum/common" | ||
| ) | ||
|
|
||
| type OrderBookChecker interface { |
atvanguard
reviewed
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this works
In commitNewWork, when committing each transactions, we check whether the order(s) in the transaction match with any existing orders, and matching transactions are included in the same block.
How this was tested
On local