fix: Clippy warnings

- Remove all clippy warnings using Rust release 1.61.
hubblo-org · Jun 25, 2022 · 2df4dcf · 2df4dcf
1 parent 6bc55c5
commit 2df4dcf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/src/exporters/mod.rs b/src/exporters/mod.rs
@@ -692,8 +692,7 @@ impl MetricGenerator {
             attributes.insert("exe".to_string(), exe.clone());
 
             if let Some(cmdline_str) = cmdline {
-                attributes.insert("cmdline".to_string(), cmdline_str.replace('\"', "\\\""));
-
+                attributes.insert("cmdline".to_string(), cmdline_str.replace('"', "\\\""));
                 if self.qemu {
                     if let Some(vmname) = utils::filter_qemu_cmdline(&cmdline_str) {
                         attributes.insert("vmname".to_string(), vmname);

diff --git a/src/exporters/prometheus.rs b/src/exporters/prometheus.rs
@@ -194,7 +194,7 @@ fn format_metric(key: &str, value: &str, labels: Option<&HashMap<String, String>
     if let Some(labels) = labels {
         result.push('{');
         for (k, v) in labels.iter() {
-            result.push_str(&format!("{}=\"{}\",", k, v.replace('\"', "_")));
+            result.push_str(&format!("{}=\"{}\",", k, v.replace('"', "_")));
         }
         result.remove(result.len() - 1);
         result.push('}');

diff --git a/src/exporters/riemann.rs b/src/exporters/riemann.rs
@@ -183,8 +183,7 @@ impl Exporter for RiemannExporter {
                 attributes.insert("exe".to_string(), exe.clone());
 
                 if let Some(cmdline_str) = cmdline {
-                    attributes.insert("cmdline".to_string(), cmdline_str.replace('\"', "\\\""));
-
+                    attributes.insert("cmdline".to_string(), cmdline_str.replace('"', "\\\""));
                     if parameters.is_present("qemu") {
                         if let Some(vmname) = utils::filter_qemu_cmdline(&cmdline_str) {
                             attributes.insert("vmname".to_string(), vmname);

diff --git a/src/exporters/warpten.rs b/src/exporters/warpten.rs
@@ -342,7 +342,7 @@ impl Warp10Exporter {
                 }
                 plabels.push(warp10::Label::new(
                     "cmdline",
-                    &cmdline_str.replace('\"', "\\\""),
+                    &cmdline_str.replace('"', "\\\""),
                 ));
             }
             let metric_name = format!(