-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Checkbox): Checkbox and CheckboxButton and CheckboxGroup #563
Conversation
# Conflicts: # packages/element3/packages/checkbox-group/CheckboxGroup.vue # packages/element3/packages/checkbox/uses.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该将代码放在src/components下
modelValue: [String, Number, Boolean, Symbol, Array], | ||
label: [String, Number, Boolean, Symbol], | ||
indeterminate: Boolean, | ||
label: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props 应该是一个单独的文件
import { setupGlobalOptions } from '../../../src/composables/globalConfig' | ||
|
||
describe('ElCheckboxButton', function () { | ||
test('default slot', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test 应该换成it 统一一下风格
请提交 PR 之前确认一下已通过