Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Checkbox): Checkbox and CheckboxButton and CheckboxGroup #563

Closed
wants to merge 42 commits into from

Conversation

qiqingfu
Copy link
Contributor

@qiqingfu qiqingfu commented Feb 1, 2021

请提交 PR 之前确认一下已通过

  1. 看过这个贡献者说明 中文
  2. 测试通过
  3. 如果有相关的 issue,记得关联上 refactor Checkbox components #463 refactor Checkbox-group component #478 refactor Checkbpx-button component #561

Copy link
Contributor

@Lydanne Lydanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该将代码放在src/components下

modelValue: [String, Number, Boolean, Symbol, Array],
label: [String, Number, Boolean, Symbol],
indeterminate: Boolean,
label: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props 应该是一个单独的文件

import { setupGlobalOptions } from '../../../src/composables/globalConfig'

describe('ElCheckboxButton', function () {
test('default slot', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test 应该换成it 统一一下风格

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants