Stop using a deprecated AdamW implementation #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
lewtun
reviewed
Jun 27, 2022
There was a problem hiding this comment.
Thanks you very much for working on this @RedTachyon! This import also occurs in:
chapter3/4.mdxchapter7/4.mdx
Would you be happy to make the changes here, as well as for all the translated sections (e.g. de/chapter3/2.mdx etc)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the transformers library,
transformers.AdamWis deprecated, and instead users should usetorch.optim.AdamWThis PR changes the import in this exact way, so that
AdamWis still imported to the global namespace (so no other code changes are necessary)