chapter 1 [ar] - section 1/1 and section 1/2 #92

hkhdair · 2022-04-05T04:23:27Z

I added the Arabic translation of chapter 2, section 1- Introduction, and 2- NLP. I also added _toctree.yml file for the first sections being translated right now. This is still a work in progress, I welcome any comments and/or reviews.

issue number : #53

lewtun

Thank you for this excellent contribution @HishamKhdair 🔥 ! From my side, the only thing to change is the _toctree.yml file to remove chapter 0

lewtun · 2022-04-05T11:45:31Z

chapters/ar/_toctree.yml

@@ -0,0 +1,11 @@
+- title: 0. الإعداد


We should remove this section as the docs won't render if we don't have the corresponding MDX file

Thanks @lewtun I will add only the sections that I worked on

Great. I will continue working on other sections of chapter 2 in the same manner.

lewtun · 2022-04-05T11:47:17Z

chapters/ar/chapter1/1.mdx

@@ -0,0 +1,58 @@
+
+<div dir="rtl" style="direction:rtl;text-align:right;">


Nice work on figuring this out! I saw we have the same issue with RTL languages in other translations and this seems to be the best way to work around the problem for now

Yes, HTML tag is the best workaround for RTL languages. This works for any RTL language.

giyaseddin

Thanks for your initiative, nice work :)

giyaseddin · 2022-04-05T15:55:52Z

chapters/ar/chapter1/1.mdx

+فيما يلي نظرة عامة موجزة عن الدورة:
+
+<div class="flex justify-center">
+<img class="block dark:hidden" src="https://huggingface.co/datasets/huggingface-course/documentation-images/resolve/main/en/chapter1/summary.svg" alt="Brief overview of the chapters of the course.">


I suggest we translate the figures as well.
@lewtun what do you think?

We currently don't have an easy mechanism for community member to contribute to the documentation-images repo, but we're working on making this possible. I suggest we leave the images in English for now and then revisit this once we can :)

giyaseddin · 2022-04-05T15:57:44Z

chapters/ar/chapter1/1.mdx

+<div class="flex justify-center">
+<img class="block dark:hidden" src="https://huggingface.co/datasets/huggingface-course/documentation-images/resolve/main/en/chapter1/summary.svg" alt="Brief overview of the chapters of the course.">
+
+- تقدم الفصول من 1 إلى 4 مقدمة للمفاهيم الرئيسية لمكتبة Transformers🤗. بنهاية هذا الجزء من الدورة التدريبية ، ستكون على دراية بكيفية عمل نماذج المحولات Transformer وستعرف كيفية استخدام نموذج من [Hugging Face Hub] (https://huggingface.co/models) ، تعديله علي مجموعة بيانات محددة ومشاركة نتائجك على Hub!


In .MD format there is no space between brackets and URL parentheses [Hypertext](URL)

giyaseddin · 2022-04-05T15:58:24Z

chapters/ar/chapter1/1.mdx

+هذه الدورة:
+
+* تتطلب معرفة جيدة بلغة البرمجة Python
+* من الأفضل أخذ هذه الدورة بعد دورة تعليمية تمهيدية ، مثل [fast.ai's] (https://www.fast.ai) [التعلم العميق العملي للمبرمجين] (https://course.fast.ai) أو أحد البرامج التي طورتها [DeepLearning.AI] (https://www.deeplearning.ai)


giyaseddin · 2022-04-05T16:02:13Z

chapters/ar/chapter1/1.mdx

+
+<Youtube id="00GKzGyWFEs" />
+
+ستعلمك هذه الدورة التدريبية حول معالجة اللغة الطبيعية (NLP) باستخدام مكتبات من نظام [Hugging Face🤗] (https://huggingface.co) - [Transformers🤗] (https://github.com/huggingface/transformers) و [Datasets🤗] (https://github.com/huggingface/datasets) و [Tokenizer🤗] (https://github.com/huggingface/tokenizers) و [Accelerate🤗] (https://github.com/huggingface/accelerate) وكذلك [Hugging Face Hub] (https://huggingface.co/models). و هذا كله مجاني تمامًا وبدون إعلانات.


I think the word منظومة may be better translation for Echosystem

Thanks @giyaseddin. it's good to agree on using the same terms for translating the upcoming sections, for consistency.

giyaseddin · 2022-04-07T18:54:13Z

chapters/ar/chapter1/1.mdx

+
+عن المؤلفين:
+
+**Matthew Carrigan** مهندس تعلم الآلة في Hugging Face. يعيش في دبلن بأيرلندا وعمل سابقًا كمهندس ML في Parse.ly وقبل ذلك كان باحثًا بعد الدكتوراه في Trinity College Dublin. إنه لا يعتقد أننا سنصل إلى الذكاء الاصطناعي العام من خلال توسيع البيئات الحالية ، ولكن لديه آمال كبيرة في خلود الروبوت بغض النظر عن ذلك.


I suggest wrapping paragraphs that start with EN words with

<div style="direction:rtl;"> </div>

because these sentences are hard to read backward->forward->backward etc.

Thanks for suggesting this @giyaseddin! @HishamKhdair if you need some additional guidance, I suggest checking out how the Farsi files were translated in the chapters/fa folder

Thanks for the comments @giyaseddin and @lewtun .

You might be not able to read it only inside .md file but the rendered page works very well. The whole content is wrapped with <div dir="rtl"> , and all sounds alright.

I checked and verified this with "Markdown Preview Enhanced" in vscode in addition to other markdown live preview tools. All seems to be correct and intact.

I noticed this by checking this link, direction confusion -especially code snippets- which might as you said not be the actual production rendering. Can't wait to see the final result.

lewtun · 2022-04-20T12:16:08Z

Hey @HishamKhdair just checking if you need any help from myself or @giyaseddin on this PR - I think it just needs a few minor tweaks and it's ready to go!

hkhdair · 2022-04-24T13:55:06Z

Hey @lewtun Section 1/1 and section 1/2 of chapter 1 are now complete. I considered all reviews, worked on some broken right-to-left embeddings in both files, and made other minor edits to the text.

HuggingFaceDocBuilderDev · 2022-05-03T11:57:55Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

lewtun · 2022-05-03T14:37:46Z

Thanks for iterating on this @hkhdair ! It seems the RTL alignment doesn't quite work for chapter1/1.mdx - would you mind seeing if it's easy to fix?

In case you wish to preview the content locally, you can first install the doc-builder lib with

pip install git+https://github.com/huggingface/doc-builder.git

and then run

doc-builder preview course ../course/chapters/ar --not_python_module

…course

hkhdair · 2022-05-15T01:45:54Z

Thanks for iterating on this @hkhdair ! It seems the RTL alignment doesn't quite work for chapter1/1.mdx - would you mind seeing if it's easy to fix?

In case you wish to preview the content locally, you can first install the doc-builder lib with
pip install git+https://github.com/huggingface/doc-builder.git
and then run
doc-builder preview course ../course/chapters/ar --not_python_module

Hi @lewtun I am really sorry for the late reply, I was not able to check this repo for a while.

I installed doc-builder as you suggested, but I was not able to preview the content locally, it went into a number of errors, I tried to fix them one by one, but still the local preview didn't work.

Anyway, I figured out that the above problem might be because of the centered image, I added another fix by wrapping it in a <div>. Would you please check if this has fixed the problem?

All .md live previews I used show that it is working fine, you can also see that everything seems intact from this file view. Hope this works now. If this is still not working, any suggestions?

giyaseddin · 2022-07-06T23:35:33Z

Hello @hkhdair
Thanks for the updates.
in this file view some of the hypertext links aren't formatted well (in the EN version, it's just a clickable text, and the url isn't visible)

Otherwise, everything seems Ok.

lewtun · 2022-08-15T08:51:12Z

Hey @hkhdair thanks a lot for fixing the centring issues with the figure - it now looks great! As @giyaseddin points out, there's one final issue with the hyptertext links:

Would you like to have a go at fixing them?

lunarflu · 2024-08-23T17:32:20Z

cc @hkhdair @giyaseddin Hey folks! 🤗 We're wrapping up some of the older PRs for this repo; Anything else to do for this one?

lewtun mentioned this pull request Apr 5, 2022

Translate to Arabic #53

Open

69 tasks

lewtun reviewed Apr 5, 2022

View reviewed changes

giyaseddin suggested changes Apr 5, 2022

View reviewed changes

giyaseddin reviewed Apr 7, 2022

View reviewed changes

hkhdair changed the title ~~chapter 2 [ar] - work in progress~~ chapter 1 [ar] - work in progress Apr 13, 2022

edited files as per reviews

57eb935

hkhdair force-pushed the ar-course branch from 9834902 to 57eb935 Compare April 24, 2022 11:41

hkhdair added 3 commits April 24, 2022 21:34

edited rtl 1.mdx

ce81893

Fixed 1.md added RIGHT-TO-LEFT EMBEDDING

a9da9ac

Fix 1.md RTL RIGHT-TO-LEFT EMBEDDING

09d2586

hkhdair changed the title ~~chapter 1 [ar] - work in progress~~ chapter 1 [ar] - section 1/1 and section 1/2 Apr 24, 2022

hkhdair added 3 commits April 24, 2022 22:44

Final fix 1.md RIGHT-TO-LEFT EMBEDDING

46c58dd

Final fix 1.md RIGHT-TO-LEFT EMBEDDING

7d97fe9

FINAL edit of section 1 and 2 (1.mdx and 2.mdx)

148b4e3

hkhdair added 3 commits May 15, 2022 10:05

Merge branch 'main' of https://github.com/huggingface/course into ar-…

859d9a8

…course

fix div

2889901

center div fix

013db7b

hkhdair added 2 commits May 15, 2022 11:39

edited-added the whole image in <div flex justify-center>

2738e92

edited-added the whole image in <div flex justify-center>

c6114d8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chapter 1 [ar] - section 1/1 and section 1/2 #92

chapter 1 [ar] - section 1/1 and section 1/2 #92

hkhdair commented Apr 5, 2022

lewtun left a comment

lewtun Apr 5, 2022

hkhdair Apr 6, 2022

hkhdair Apr 6, 2022

lewtun Apr 5, 2022

hkhdair Apr 6, 2022

giyaseddin left a comment

giyaseddin Apr 5, 2022

lewtun Apr 5, 2022

giyaseddin Apr 5, 2022

giyaseddin Apr 5, 2022

giyaseddin Apr 5, 2022

hkhdair Apr 6, 2022

giyaseddin Apr 7, 2022

lewtun Apr 12, 2022

hkhdair Apr 13, 2022

giyaseddin Apr 13, 2022

lewtun commented Apr 20, 2022

hkhdair commented Apr 24, 2022

HuggingFaceDocBuilderDev commented May 3, 2022

lewtun commented May 3, 2022

hkhdair commented May 15, 2022

giyaseddin commented Jul 6, 2022

lewtun commented Aug 15, 2022

lunarflu commented Aug 23, 2024

		@@ -0,0 +1,58 @@

		<div dir="rtl" style="direction:rtl;text-align:right;">


		<Youtube id="00GKzGyWFEs" />

		ستعلمك هذه الدورة التدريبية حول معالجة اللغة الطبيعية (NLP) باستخدام مكتبات من نظام [Hugging Face🤗] (https://huggingface.co) - [Transformers🤗] (https://github.com/huggingface/transformers) و [Datasets🤗] (https://github.com/huggingface/datasets) و [Tokenizer🤗] (https://github.com/huggingface/tokenizers) و [Accelerate🤗] (https://github.com/huggingface/accelerate) وكذلك [Hugging Face Hub] (https://huggingface.co/models). و هذا كله مجاني تمامًا وبدون إعلانات.


		عن المؤلفين:

		Matthew Carrigan مهندس تعلم الآلة في Hugging Face. يعيش في دبلن بأيرلندا وعمل سابقًا كمهندس ML في Parse.ly وقبل ذلك كان باحثًا بعد الدكتوراه في Trinity College Dublin. إنه لا يعتقد أننا سنصل إلى الذكاء الاصطناعي العام من خلال توسيع البيئات الحالية ، ولكن لديه آمال كبيرة في خلود الروبوت بغض النظر عن ذلك.

chapter 1 [ar] - section 1/1 and section 1/2 #92

Are you sure you want to change the base?

chapter 1 [ar] - section 1/1 and section 1/2 #92

Conversation

hkhdair commented Apr 5, 2022

lewtun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giyaseddin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lewtun commented Apr 20, 2022

hkhdair commented Apr 24, 2022

HuggingFaceDocBuilderDev commented May 3, 2022

lewtun commented May 3, 2022

hkhdair commented May 15, 2022

giyaseddin commented Jul 6, 2022

lewtun commented Aug 15, 2022

lunarflu commented Aug 23, 2024