Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #7365, prevent pipelines from overriding provided prompt embeds #7926

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bghira
Copy link
Contributor

@bghira bghira commented May 12, 2024

What does this PR do?

Fixes #7365

Before submitting

Who can review?

@sayakpaul @yiyixuxu

@bghira bghira force-pushed the issue/7365b branch 2 times, most recently from 4ce77f5 to 992d2df Compare May 12, 2024 16:42
@sayakpaul sayakpaul requested a review from yiyixuxu May 13, 2024 09:53
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu
Copy link
Collaborator

why are all the tests failing?

@yiyixuxu
Copy link
Collaborator

can we look into the remaining failing tests?

@bghira
Copy link
Contributor Author

bghira commented May 20, 2024

wow, i hadn't expected all of those, or really looked into them until now. i'm not sure why this simple check made those tests fail. i am wondering if there's something i need to check first before assigning the prompt embeds 🤔 like whether we have any? should i try and run the unit tests locally again?

@bghira
Copy link
Contributor Author

bghira commented May 26, 2024

@yiyixuxu i was trying again today and make test doesn't work here as i guess i don't have the right version of pytest installed, and now running pip install diffusers[dev] but i think there must be a way to run this in a Docker container?

edit: after pip install diffusers[dev] it now works to run make test

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bghira! Apologies for the delay on my part. Would it be possible to add a test for this to https://github.com/huggingface/diffusers/blob/main/tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl.py?

@bghira
Copy link
Contributor Author

bghira commented Nov 23, 2024

cc @a-r-r-o-w for test

@sayakpaul
Copy link
Member

Yeah let's ensure to add at least one test before merging.

@bghira
Copy link
Contributor Author

bghira commented Nov 23, 2024

was having trouble getting the test suite running when i pushed this and my new system doesn't have it working yet either - but a regression test would be great to keep it workin

@github-actions github-actions bot removed the stale Issues that haven't received updates label Nov 23, 2024
@sayakpaul
Copy link
Member

Seems like the core tests are failing with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provided pooled_prompt_embeds is overwritten via prompt_embeds[0]
5 participants