-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #7365, prevent pipelines from overriding provided prompt embeds #7926
base: main
Are you sure you want to change the base?
Conversation
4ce77f5
to
992d2df
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
why are all the tests failing? |
can we look into the remaining failing tests? |
wow, i hadn't expected all of those, or really looked into them until now. i'm not sure why this simple check made those tests fail. i am wondering if there's something i need to check first before assigning the prompt embeds 🤔 like whether we have any? should i try and run the unit tests locally again? |
@yiyixuxu i was trying again today and edit: after |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bghira! Apologies for the delay on my part. Would it be possible to add a test for this to https://github.com/huggingface/diffusers/blob/main/tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl.py?
cc @a-r-r-o-w for test |
Yeah let's ensure to add at least one test before merging. |
was having trouble getting the test suite running when i pushed this and my new system doesn't have it working yet either - but a regression test would be great to keep it workin |
Seems like the core tests are failing with the changes. |
What does this PR do?
Fixes #7365
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @yiyixuxu