Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test assertion in test_trainer.py #477

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

slowder
Copy link
Contributor

@slowder slowder commented Nov 25, 2023

Fix: replace incorrect call to assertTrue with assertEqual

What does this PR do?

As originally written, the call to assertTrue simply asserts that the len(preds) is a truthy value rather than comparing to the second argument.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Fix incorrect call to assertTrue to be assertEqual
Copy link
Contributor

@jimypbr jimypbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@jimypbr jimypbr merged commit d415c9e into huggingface:main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants