fix: address race condition and consider transition time when using debounce #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cayossarian
force-pushed
the
fix/state_change_race_condition
branch
3 times, most recently
from
98eac5d to
e48986e
Compare
Fix race condidtiion in state change. Rapid state changes caused a race condition due to the use of sleep methods which should not be used in HA. This change uses the HA event loop to schedule the state change and ensures that the debounce time follows any transition time.
cayossarian
force-pushed
the
fix/state_change_race_condition
branch
from
e48986e to
1791d4b
Compare
|
Brilliant, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issuse #166 race condition
This pull request does a few things to address the race condition:
The UI switch remains responsive so the user can turn the scene on/off at will. When the user changes the stateful scene during a period where the transition or debounce is in play the scene changes state as would be expected and resets any pending delay in evaluation.
If an external source changes one of the entities that the scene controls during the transition/debounce the final evaluation will occur and set the stateful scene accordingly.