Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid multiple threads on the same scene #173

Conversation

cayossarian
Copy link
Contributor

@cayossarian cayossarian commented Dec 31, 2024

Change all eval related methods to async

Sounds like one of those folks that had hang verified that this PR resolves their issue.

Addresses issue #170

@cayossarian cayossarian force-pushed the fix/avoid_multiple_threads_on_same_scene branch 2 times, most recently from c4319a9 to 34aeb51 Compare December 31, 2024 20:24
@cayossarian cayossarian changed the title fix: Avoid multiple threads on the same scene by fix: Avoid multiple threads on the same scene Dec 31, 2024
@cayossarian cayossarian force-pushed the fix/avoid_multiple_threads_on_same_scene branch from 34aeb51 to eecba61 Compare December 31, 2024 23:29
remove unused import

Statisfy Ruff for switch import platform schema

Add async_cancel_if_active to avoid calling
async_executor_job
@cayossarian cayossarian force-pushed the fix/avoid_multiple_threads_on_same_scene branch from eecba61 to f6bb5a0 Compare December 31, 2024 23:34
@cayossarian cayossarian marked this pull request as draft January 1, 2025 05:10
@cayossarian
Copy link
Contributor Author

Closed in favor of PR #175

@cayossarian cayossarian closed this Jan 1, 2025
@cayossarian cayossarian deleted the fix/avoid_multiple_threads_on_same_scene branch January 2, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant