Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log remote requests made by the AWS SDK #133

Merged
merged 8 commits into from
Feb 19, 2020

Conversation

dashaluna
Copy link
Contributor

Fixes #125

@dashaluna dashaluna requested a review from roborourke February 6, 2020 11:33
@roborourke
Copy link
Contributor

Tested this out locally with the audit-log-to-cloudwatch feature on and the SDK params filter is applied.

@joehoyle @rmccue can you think of any other key things to help test this locally? Can you see any issue with where the filter is?

@rmccue
Copy link
Member

rmccue commented Feb 6, 2020

@joehoyle @rmccue can you think of any other key things to help test this locally? Can you see any issue with where the filter is?

Let's roll it onto a development stack and test against the live service.

@roborourke
Copy link
Contributor

Will update platform-test to run this branch 👍

@rmccue rmccue self-assigned this Feb 12, 2020
load.php Show resolved Hide resolved
@rmccue
Copy link
Member

rmccue commented Feb 12, 2020

With the above change, I'm now seeing requests come in, however the data on them appears to be wrong. See Slack for more.

@rmccue
Copy link
Member

rmccue commented Feb 12, 2020

Filed humanmade/aws-xray#54 for the invalid-ish data.

We can move ahead with this in the meantime. With the above change, it should be good to go.

@rmccue rmccue assigned roborourke and unassigned rmccue Feb 12, 2020
@rmccue
Copy link
Member

rmccue commented Feb 12, 2020

Ah, we probably need to add aws_ses_wp_mail_ses_client_params too.

@roborourke
Copy link
Contributor

Woot

@joehoyle
Copy link
Member

Do we need to do anything else for this PR, or shall we merge and add follow-ups for the other items?

Co-Authored-By: Ryan McCue <[email protected]>
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joehoyle yeah, so remaining issues are to ensure the same arguments are applied to all our other plugins that create their own client instance, or update our plugins to check for the Altis one first.

@roborourke roborourke merged commit 12d660f into master Feb 19, 2020
@roborourke roborourke deleted the add-aws-xray-params-via-filter branch February 19, 2020 13:46
@roborourke
Copy link
Contributor

Added AWS SES params filter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log remote requests made by the AWS SDK
4 participants