-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log remote requests made by the AWS SDK #133
Conversation
Will update |
With the above change, I'm now seeing requests come in, however the data on them appears to be wrong. See Slack for more. |
Filed humanmade/aws-xray#54 for the invalid-ish data. We can move ahead with this in the meantime. With the above change, it should be good to go. |
Ah, we probably need to add |
Woot |
Do we need to do anything else for this PR, or shall we merge and add follow-ups for the other items? |
Co-Authored-By: Ryan McCue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joehoyle yeah, so remaining issues are to ensure the same arguments are applied to all our other plugins that create their own client instance, or update our plugins to check for the Altis one first.
Added AWS SES params filter as well. |
Fixes #125