Add a command for cloud-build #540
Conversation
So people can more easily test the builds as if there were in cloud, I've added a command that will run their `.build-script` using the same `build-container` that we used in CodeBuild.
| @@ -172,6 +172,8 @@ protected function execute( InputInterface $input, OutputInterface $output ) { | |||
| return $this->shell( $input, $output ); | |||
| } elseif ( $subcommand === 'import-uploads' ) { | |||
| return $this->import_uploads( $input, $output ); | |||
| } elseif ( $subcommand === 'cloud-build' ) { | |||
There was a problem hiding this comment.
I think the intention is to test that a build runs without errors, and doesn't actually produce a build that can be deployed to Altis, so build may be a bit misleading.
I was going to ask the same and went down a rabbit hole into how to force a volume mount with an overlay filesystem. Turned out to be a bit trickier than I though, but copying into a non-host directory and running the build there would also be okay I suppose. |
Yeah, I'd copy it probably. |
|
Hmm yeah if we want this to be a "readonly" operation, we'd need to do things a bit differently. We could increase the scope to run the "build process" from Altis Cloud (not just the build script), so that would mean: |
|
That's one of the reasons I was hoping to have an overlay filesystem. With Doing a copy and excluding things in .gitignore may be a good balance. |
|
What if we make it the user's choice? By default, |
|
Wouldn't the commit still have to exist in the remote? And if so, wouldn't it likely already have a remote build available/running in Vantage? |
|
Not necessarily, it can use your local commits which may not have been pushed; additionally, you're likely pushing to a feature branch which isn't getting built in Vantage, not one of the deploy branches. |
Co-authored-by: Ryan McCue <[email protected]>
So people can more easily test the builds as if there were in cloud, I've added a command that will run their
.build-scriptusing the samebuild-containerthat we used in CodeBuild.