Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include http data on CLI #73

Closed
wants to merge 1 commit into from
Closed

Do not include http data on CLI #73

wants to merge 1 commit into from

Conversation

roborourke
Copy link
Contributor

Fixes #72

@roborourke roborourke requested review from joehoyle and rmccue July 24, 2020 15:39
hm-linter[bot]
hm-linter bot reviewed Jul 24, 2020
View reviewed changes
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (2 errors).

2 notices occurred in your codebase, but none on files/lines included in this PR.

@roborourke
Copy link
Contributor Author

My other thought is that perhaps this should add data from the CLI invocation? Could do that in a follow up. I'm thinking things like $argv and $argc, the command itself, anything extra we can infer from WP CLI commands specifically.

@roborourke
Copy link
Contributor Author

XRay shouldn't be run in a non HTTP context so the issue this addresses can be handled upstream.

@roborourke roborourke closed this Jul 31, 2020
@roborourke roborourke deleted the no-http-data-on-cli branch July 31, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter[bot] left review comments

@joehoyle joehoyle Awaiting requested review from joehoyle

@rmccue rmccue Awaiting requested review from rmccue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_in_progress_trace assumes HTTP context
1 participant
@roborourke