Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily ignore RUSTSEC-2024-0421 #1362

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Temporarily ignore RUSTSEC-2024-0421 #1362

merged 1 commit into from
Dec 11, 2024

Conversation

dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Dec 11, 2024 •
edited
Loading

https://rustsec.org/advisories/RUSTSEC-2024-0421

We have internal dependencies (libp2p) that depends on vulnerable idna version.

Based on the vulnerability description looks like we can ignore it for now.

quasiyoke
quasiyoke approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@quasiyoke quasiyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vulnerability would be significant for us if we allowed users to distribute URLs to other users and we had, say, a blacklist of some resources. AFAIK, this vulnerability should not cause problems for us.

@MOZGIII
Copy link
Contributor

MOZGIII commented Dec 11, 2024

This is actually an exploitable issue

@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 380ebde Dec 11, 2024
21 checks passed
@dmitrylavrenov dmitrylavrenov deleted the ignore-RUSTSEC-2024-0421 branch December 11, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiyoke quasiyoke quasiyoke approved these changes

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees
No one assigned
Labels
security
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrylavrenov @MOZGIII @quasiyoke