Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the token claims validation logic CheckTokenClaim #1368

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Correct the token claims validation logic CheckTokenClaim #1368

merged 3 commits into from
Dec 13, 2024

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Dec 12, 2024 •
edited
Loading

Analogus to #1366, this is a slight correction to the CheckTokenClaim

dmitrylavrenov
dmitrylavrenov approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the explicit invalid call for unsigned case!

LGTM

@MOZGIII MOZGIII added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 7a31b4a Dec 13, 2024
21 checks passed
@MOZGIII MOZGIII deleted the token-claims-validity-check-fix branch December 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylavrenov dmitrylavrenov dmitrylavrenov approved these changes

@quasiyoke quasiyoke quasiyoke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MOZGIII @quasiyoke @dmitrylavrenov