Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/clean up repo #24

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Feat/clean up repo #24

merged 8 commits into from
Jul 18, 2024

Conversation

cardosofede
Copy link
Contributor

Changes:

  • added isort, black, flake and pre-commit
  • format all the files
  • remove unused modules

@rapcmia rapcmia requested review from rapcmia and nikspz July 18, 2024 11:03
rapcmia
rapcmia approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rapcmia rapcmia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Setup this PR with dashboard PR160, broker from deploy docker compose and deploy successfully hummingbot PR7121 image
  • Added account and credentials
    • Create, update and remove random connectors
    • Check portfolio matched on exchange current assets
  • Ran backtests few backtesting using kucoin and binance on PMM_simple and PMM_dynamic
  • Ran random configs and switched to other controllers to check possible mixed setup, all ok
  • Ran random configs and deploy using kucoin and binance_perpetual as connector ok
  • Issue with libcxx has been fixed

QA approved 1/2

@rapcmia rapcmia mentioned this pull request Jul 18, 2024
Merged
nikspz
nikspz approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • docker running ok
  • available_images ok
  • active_containers ok
  • exited: ok
  • /get-active-bots-status: ok
  • stop bot: ok
  • remove_container: ok
  • /get-active-bots-status: ok

@nikspz nikspz merged commit 5dd8d41 into development Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikspz nikspz nikspz approved these changes

@rapcmia rapcmia rapcmia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cardosofede @rapcmia @nikspz