Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add observability and security #37

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Feat/add observability and security #37

merged 8 commits into from
Nov 1, 2024
+258 −8

Conversation

cardosofede
Copy link
Contributor

@cardosofede cardosofede commented Oct 13, 2024 •
edited by nikspz
Loading

Changes:

  1. controllers/generic/grid_strike.py added
  2. main.py added auth for user
  3. set_environment.sh added credentials
  4. to (f"Error getting last traded prices in connector {connector} for trading pairs {trading_pairs}: {e}")

@notion-workspace Notion Workspace
Copy link

Feat/add observability and security #37

@rapcmia rapcmia requested a review from nikspz October 29, 2024 04:41
@cardosofede cardosofede changed the base branch from main to development October 29, 2024 21:35
@cardosofede cardosofede mentioned this pull request Oct 31, 2024
Merged
@rapcmia rapcmia self-requested a review October 31, 2024 06:37
@rapcmia
Copy link
Contributor

rapcmia commented Oct 31, 2024

  • Setup with dashboard PR188 on source ✅
  • Confirmed generic.grid_strike now available todo: test with quantslab
  • Run set_environment.sh
    image
    • Check .env file, typo on line 16? ❌
      image
      image
  • Unlisted markets now showing the connector ✅
    image

Advised @nikspz to test docker build

@rapcmia rapcmia changed the base branch from development to main November 1, 2024 15:14
@rapcmia rapcmia merged commit 9bcf5f2 into main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapcmia rapcmia rapcmia approved these changes

@nikspz nikspz Awaiting requested review from nikspz

Assignees
No one assigned
Labels
None yet
Projects
Pull Request Status
Status: Development 2.2.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardosofede @rapcmia