Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add dashboard auth #58

Merged
merged 18 commits into from
Jul 30, 2024
Merged

Feat/add dashboard auth #58

merged 18 commits into from
Jul 30, 2024

Conversation

cardosofede
Copy link
Contributor

@cardosofede cardosofede commented Jul 22, 2024

This PR has the following changes:

  • Add auth system back for deploy repo
  • Make the dashboard pages editable by creating a mount

@rapcmia rapcmia requested review from rapcmia and nikspz July 24, 2024 02:13
@rapcmia
Copy link
Contributor

rapcmia commented Jul 24, 2024

Test in progress

@nikspz
Copy link
Contributor

nikspz commented Jul 24, 2024

Still ongoing:

cc: hummingbot/dashboard#157 (comment)

  1. Page refresh will lead to user Logged out

After you added connector you need to refresh the page to reflect the changes, however it will lead to user logged out

  1. Minor

Actual: Logout button available only for Humingbot Dashboard tab on side pane (if you are on other tab you could not log out)

@rapcmia
Copy link
Contributor

rapcmia commented Jul 24, 2024

PR update:

  • Ran tests using docker-compose-dev.yml
  • By default, auth is set to false and can be viewed when clicking the title pages ✅

What happens if you logout?
image

  • When auth is false (default):
    • Successfully logout even closing the browser and opened it still ask us to login again
    • Cleared cache, still require to login
    • Logged in again ok
      • Dashboard would ask to login again when:
        • Refresh browser
        • Clear cached
    • Relaunch docker compose again but still it prompt for user login, see recording https://www.loom.com/share/d32742ccd8fd4de4983b4a7bf935be67
    • Q: Should dashboard not prompt for login when AUTH_SYSTEM_ENABLED is false?

@rapcmia rapcmia requested a review from david-hummingbot July 26, 2024 07:07
@rapcmia
Copy link
Contributor

rapcmia commented Jul 26, 2024

PR update:

  • Pull latest development update for both backendapi and dashboard
  • Build docker image locally and use on deploy -> docker-compose-dev.yml file
  • Run docker compose successfully:

@david-hummingbot
Copy link
Contributor

Found the issue, the environment variable in the compose file wasn't getting picked up by the config.py file. Opened PR - hummingbot/dashboard#168 to fix the issue. After making the change the auth_system works when setting to either true or false

image

image

@rapcmia rapcmia merged commit 52d1658 into main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants