Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rubicon #356

Open
wants to merge 14 commits into
base: development
Choose a base branch
from
Open

Conversation

etherealiska
Copy link

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This is the main pr for Rubicon gateway. The functionality of this connector can be accessed through the endpoints on the clob routes combined with the endpoints on the network routes.

Tests performed by the developer:
All unit tests are passing, and manually tested with hummingbots pure MM strategy.

fengtality and others added 11 commits July 3, 2024 07:26
sync / gateway staging -> master for Hummingbot gateway version 2.0.0
sync / gateway development -> staging
fix/ adding uniswap updates PR to gateway staging
…ion-to-2.0.1

Fix gw staging version to 2.0.1
sync / gateway staging -> master for Hummingbot gateway version 2.0.1
* Scaffolding

* Add rubicon configs

* Add base and arb sepolia tokens

* sepolia tokens

* Add rubicon to connectors

* Add rubicon to valid spender list

* Working gateway

* ensure pk is set to sign orders

* url typo

* calculate markets dynamically

* Add keys to config

* Add fake private key

* Calculate slippage into output amount

* Use gateway to get wallet

* No decaying orders

* Networks must be lowercased

* Return empty ticker if there is no subgraph for trades

* Tests

* Fixed unit tests
@nikspz nikspz changed the base branch from main to development September 10, 2024 02:04
@nikspz
Copy link
Contributor

nikspz commented Sep 10, 2024

hi @etherealiska, PR should be pointed to development branch
https://hummingbot.org/developers/contributions/
https://hummingbot.org/developers/contributions/#checklist

@rapcmia rapcmia self-requested a review October 16, 2024 06:57
@rapcmia rapcmia mentioned this pull request Oct 16, 2024
@rapcmia
Copy link
Contributor

rapcmia commented Oct 18, 2024

PR update:

  • Setup gateway failed
    image
    • Possible due branch conflicts, please update PR with the latest development

@rapcmia
Copy link
Contributor

rapcmia commented Nov 4, 2024

@etherealiska ill be moving this task to on hold until PR is updated to latest development

@rapcmia rapcmia requested review from nikspz and removed request for rapcmia November 7, 2024 02:57
@nikspz
Copy link
Contributor

nikspz commented Dec 12, 2024

hi @etherealiska Please resolve all the conflicts and update branch to latest development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Dev Work
Development

Successfully merging this pull request may close these issues.

5 participants