Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin uses quite old version of cni library #22

Open
jellonek opened this issue Nov 15, 2017 · 1 comment
Open

Plugin uses quite old version of cni library #22

jellonek opened this issue Nov 15, 2017 · 1 comment

Comments

@jellonek
Copy link
Contributor

Current version of this SR-IOV plugin uses quite old version of cni library and so, it returns types.Result in old form (probably compatible with 0.2.0 version of spec) which e.g. don't have interfaces list.

This issue is a place to track state of update of this dependency, hopefully to current stable https://github.com/containernetworking/cni/tree/v0.6.0

@hustcat
Copy link
Owner

hustcat commented Nov 15, 2017

Yeah, we need to update CNI library to support CNI v0.6+

jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 16, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 16, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 17, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 20, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 21, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 21, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek added a commit to Mirantis/virtlet that referenced this issue Nov 27, 2017
This change should improve overal support for cni plugins returning
[Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result)
in form compatible with v0.2.0 of specification.

E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants