[wip] nettools: Better support for old cni plugins #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This change should improve overal support for cni plugins returning [Result](https://github.com/containernetworking/cni/blob/master/SPEC.md#result) in form compatible with v0.2.0 of specification. E.x. of such plugin is `bridge` used in our e2e, but also [SR-IOV](hustcat/sriov-cni#22).
jellonek
force-pushed
the
jell/old_plugins_support
branch
from
5f4d7cd to
434387f
Compare
jellonek
changed the title
|
Superseded by #508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rethinking: that's based on wrong approach. Requires a new logic to extract info about network interfaces in container namespace (already coded in separate branch) and a method to correlate internal with external interfaces.
This change should improve overal support for cni plugins returning Result
in form compatible with v0.2.0 of cni specification.
E.g. of such plugin is
bridgeused in our e2e, but also SR-IOV.This change is