This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
srt: add authentication to srtsink and srtsrc elements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhaakon
suggested changes
Oct 23, 2020
raghaven447
force-pushed
the
srt-dev-branch
branch
from
0355740
to
0023de5
Compare
justinjoy
suggested changes
Oct 26, 2020
raghaven447
force-pushed
the
srt-dev-branch
branch
from
0023de5
to
2b9b7be
Compare
xhaakon
suggested changes
Oct 26, 2020
| static gint | ||
| srt_listen_callback_func(GstSRTObject * self, SRTSOCKET sock, int hs_version, | ||
| const struct sockaddr* peeraddr, const char* stream_id) { | ||
| g_autoptr (GSocketAddress) addr = peeraddr_to_g_socket_address (peeraddr); |
There was a problem hiding this comment.
I think at least MSVC doesn't support g_autoptr and the like. We couldn't care less for MSVC in Hwangsaeul, but in upstream GStreamer autocleanup is better avoided.
There was a problem hiding this comment.
Yes, the Hwangsaeul project supports only the Linux platform and the latest GLib, but GStreamer-wise, we should follow their rules.
xhaakon
reviewed
Oct 26, 2020
| return 0; | ||
| reject: | ||
| /* notifying caller-rejected */ | ||
| g_signal_emit_by_name (self->element, "caller-rejected"); |
There was a problem hiding this comment.
I'd add some information that identify the rejected caller into the callback. Let's put addr and stream_id as parameters, same as "caller-connecting".
Backporting the upstream patches.
raghaven447
force-pushed
the
srt-dev-branch
branch
from
2b9b7be
to
0556285
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.