Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Set note pan" statusmessage + other changes in the note properties ruler and pan value input #1015

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

oddtime
Copy link
Contributor

@oddtime oddtime commented Dec 10, 2020

pan
This message was missing
Allows to know if pan is Right or Left (since there's no indication on the note editor ruler) and the value.
Minimal solution to issue #948

made some messages translatable
reduced size of buffer strings

The display format of the pan value can be discussed, right now is from 1.00L to 0.00L, C, from 0.00R to 1.00R.
Another fashion could be: L100 to L0, C, R0 to R100

// edit: "L","R" marks on not pan editor background added

@trebmuh
Copy link
Member

trebmuh commented Dec 10, 2020

LGTM.
Is there any chance for the "R" & "L" to be translatable? or maybe it's already the case?

@oddtime
Copy link
Contributor Author

oddtime commented Dec 10, 2020

Not now but I can do it

@trebmuh
Copy link
Member

trebmuh commented Dec 10, 2020

It'd be awesome.

@oddtime oddtime changed the title Adding "Set note pan" message (Note Properties Ruler) Adding "Set note pan" message + "R,L" on Pan NotePropertiesRuler background Dec 10, 2020
@oddtime
Copy link
Contributor Author

oddtime commented Dec 10, 2020

screenshot-0230ec97
See #948
Unfortunately the text is fixed on background (it scrolls with it) but for now we can live with it.

@oddtime oddtime marked this pull request as draft February 5, 2021 23:41
@oddtime oddtime marked this pull request as ready for review February 6, 2021 15:42
@oddtime oddtime marked this pull request as draft April 13, 2021 10:05
@oddtime oddtime changed the base branch from master to development April 13, 2021 10:06
@oddtime oddtime changed the title Adding "Set note pan" message + "R,L" on Pan NotePropertiesRuler background Adding "Set note pan" statusmessage + "R,L" on Pan NotePropertiesRuler background + use pan law (Sampler) functions for pan setting Apr 13, 2021
@oddtime
Copy link
Contributor Author

oddtime commented Apr 13, 2021

I have changed the code to input pan from GUI calling the pan law methods (the ones in Sampler class). This solves #1167.
Maybe a factorization here would be useful (similar lines are coded in both "mouse move" and "mouse wheel" functions...), I would leave this as it concerns all the note properties if I am not wrong.

@oddtime oddtime changed the title Adding "Set note pan" statusmessage + "R,L" on Pan NotePropertiesRuler background + use pan law (Sampler) functions for pan setting Adding "Set note pan" statusmessage + other changes in the note properties ruler and pan value input Apr 13, 2021
@oddtime oddtime marked this pull request as ready for review April 13, 2021 14:08
@oddtime
Copy link
Contributor Author

oddtime commented Apr 19, 2021

Actually I am doubting the necessity of still having pan_l and pan_r in Note and Instrument classes, I opened an issue: #1242
I am tempted to deprecate them and get a one to one correspondence between the widgets value and the new unique pan member

@oddtime oddtime marked this pull request as draft April 24, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants