AppVeyor: install and include OpenSSL #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt5 does not include OpenSSL libraries it was build against. See https://forum.qt.io/topic/95700/qsslsocket-tls-initialization-failed/18 As a result we have to make sure a compatible libssl.dll and libcrypto.dll is included in PATH when the software is loaded. It seems not to be detected by our Python dependency script. So, I added it manually like the JACK library. Important: when upgrading/downgrading the Qt version a different version of OpenSSL might be required. One has to manually check the version it was build against https://wiki.qt.io/Qt_5.15_Tools_and_Versions#windows_10_x86_64_7. But this can also be abstracted by a unit test as soon as the GUI can also be covered (I think we have to build a dedicated library as in hydrogen-music#1329 first).
theGreatWhiteShark
force-pushed
the
phil-fix-windows-ssl-support
branch
from
8d88dc3 to
0f26fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt5 does not include OpenSSL libraries it was build against. See https://forum.qt.io/topic/95700/qsslsocket-tls-initialization-failed/18
As a result we have to make sure a compatible libssl.dll and libcrypto.dll is included in PATH when the software is loaded. It seems not to be detected by our Python dependency script. So, I added it manually like the JACK library.
Important: when upgrading/downgrading the Qt version a different version of OpenSSL might be required. One has to manually check the version it was build against https://wiki.qt.io/Qt_5.15_Tools_and_Versions#windows_10_x86_64_7.
But this can also be abstracted by a unit test as soon as the GUI can also be covered (I think we have to build a dedicated library as in #1329 first).