Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libnsdfile.rb to recent #2049

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cme
Copy link
Contributor

@cme cme commented Oct 17, 2024

No description provided.

@theGreatWhiteShark
Copy link
Contributor

Hmmm... If the previous version of libsndfile was 1.0.31, both FLAC and Ogg/Opus support should have been working. But cmake within the AppVeyor pipeline reported otherwise.

* libsndfile                   : + used ( /usr/local/lib/libsndfile.dylib )
*                                FLAC: not supported, OGG/Vorbis: not supported (>=1.0.17 required)
 				 OGG/Opus: not supported (>=1.0.28 required)
 				 MP3: not supported (>=1.0.31 required)

(from your latest commit https://ci.appveyor.com/project/mauser/hydrogen/builds/50817210/job/namux946l3r43sqw)

Is MP3 support in the resulting binary working or does the version check in CMakeLists.txt messes up things because it can not determine the version of the shared library?

@cme
Copy link
Contributor Author

cme commented Oct 18, 2024

Hmmm... If the previous version of libsndfile was 1.0.31, both FLAC and Ogg/Opus support should have been working. But cmake within the AppVeyor pipeline reported otherwise.

* libsndfile                   : + used ( /usr/local/lib/libsndfile.dylib )
*                                FLAC: not supported, OGG/Vorbis: not supported (>=1.0.17 required)
 				 OGG/Opus: not supported (>=1.0.28 required)
 				 MP3: not supported (>=1.0.31 required)

Hmm, not sure, BUT I remembered that the Homebrew dependencies that we build are cached in the Appveyor cache. I've updated the tag to rebuild them, that might help it.

@theGreatWhiteShark
Copy link
Contributor

Well, I already thought about possible ways to circumvent the 60 minute timeout to allow for brew to compile all dependencies. Like having two separated OS jobs using the same cache which both compile half of the dependencies and do only run in case of a cache miss.

But it turns out the timeout can be configured in AppVeyor's preferences. I increased it to 120 minute and run the OS job again. Let's see if this already does the job.

@theGreatWhiteShark
Copy link
Contributor

But it turns out the timeout can be configured in AppVeyor's preferences. I increased it to 120 minute and run the OS job again. Let's see if this already does the job.

Well. Seems like "greater values does not apply to [our] plan".

@cme
Copy link
Contributor Author

cme commented Oct 19, 2024

But it turns out the timeout can be configured in AppVeyor's preferences. I increased it to 120 minute and run the OS job again. Let's see if this already does the job.

Well. Seems like "greater values does not apply to [our] plan".

Good grief, it seems to be rebuilding qt. That 'aint right. Maybe Howebrew needs to be updated before building the things that need explicitly rebuilt for the ABI change. I'll check.

@cme cme force-pushed the cme-update-libsndfile branch from b4f363f to f3c938c Compare October 19, 2024 08:18
@cme
Copy link
Contributor Author

cme commented Oct 19, 2024

Aaaha, Homebrew have removed support for Monterey. Looks like we'll have to update to a newer macOS image. I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants