Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3fs #36

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add s3fs #36

merged 2 commits into from
Dec 1, 2023

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Dec 1, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Add s3fs to environment-dev and pyproject.toml.
  • Adds a Personal Access Token to the actions-version-updater.yml

Does this PR introduce a breaking change?

No.

Other information:

@sebastienlanglois The requirements in general will need some love, but I think that it would be better if you're the one to do it. Even going back to v0.2.10, there are inconsistencies between environment.yml, setup.py, and requirements.txt, so it's hard to know what's really required or not...

@RondeauG RondeauG requested a review from Zeitsperre December 1, 2023 14:55
Copy link

github-actions bot commented Dec 1, 2023

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst and .zenodo.json.:

  • The relevant author information has been added to AUTHORS.rst and .zenodo.json.

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@RondeauG
Copy link
Collaborator Author

RondeauG commented Dec 1, 2023

  • The relevant author information has been added to AUTHORS.rst and .zenodo.json.

I'll keep that for when I actually contribute. This is just a very small requirement fix.

@Zeitsperre Zeitsperre merged commit 4e74194 into master Dec 1, 2023
7 checks passed
@Zeitsperre Zeitsperre deleted the s3fs branch December 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3fs missing from pyproject
2 participants