Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xarray can't index from lazy coordinates so we make sure to load them… #46

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

sebastienlanglois
Copy link
Contributor

@sebastienlanglois sebastienlanglois commented Jan 11, 2024

… if lazy or leave them as object if not

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Small fix to support hydrometric queries when coordinates are lazy.

Does this PR introduce a breaking change?

No

Other information:

@sebastienlanglois sebastienlanglois self-assigned this Jan 11, 2024
@sebastienlanglois sebastienlanglois merged commit fdb9b86 into master Jan 11, 2024
7 checks passed
@sebastienlanglois sebastienlanglois deleted the lazy_coordinates_support branch January 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant