Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable readthedocs builds #67

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Enable readthedocs builds #67

merged 9 commits into from
Feb 16, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Feb 5, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Deactivates the GitHub-Pages deployment
  • Constrains the temporal range of many of the notebooks examples in order to not overload memory limitations on ReadTheDocs

Does this PR introduce a breaking change?

Yes. Docs will now be served via ReadTheDocs

Other information:

This PR is just waiting on #60

@Zeitsperre Zeitsperre self-assigned this Feb 5, 2024
@Zeitsperre
Copy link
Contributor Author

@sebastienlanglois Do you have an account on www.readthedocs.org? I can add you as a maintainer (both here and for xhydro) if you pass me your account name.

@Zeitsperre Zeitsperre requested a review from RondeauG February 13, 2024 20:09
@github-actions github-actions bot added the CI Continuous Integration label Feb 16, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zeitsperre Zeitsperre requested a review from RondeauG February 16, 2024 19:01
@Zeitsperre Zeitsperre merged commit d14de90 into main Feb 16, 2024
23 checks passed
@Zeitsperre Zeitsperre deleted the readthedocs branch February 16, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace GitHub Pages with ReadTheDocs
2 participants