Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter template #83

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Update cookiecutter template #83

merged 7 commits into from
Feb 29, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Feb 28, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the cookiecutter template to the latest commit
  • Addresses a handful of misconfigurations in the workflows
  • Updates ruff to v0.2.0 and black to v24.2.0

Does this PR introduce a breaking change?

Nope.

Other information:

The cache-cleaner.yml workflow was prevented from running properly due to some missing privileges. This has been addressed.

@Zeitsperre Zeitsperre self-assigned this Feb 28, 2024
@github-actions github-actions bot added the CI Continuous Integration label Feb 28, 2024
Zeitsperre and others added 4 commits February 28, 2024 16:42
<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #82 
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [ ] CHANGES.rst has been updated (with summary of main changes).
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Pins intake below v2.0.0

### Does this PR introduce a breaking change?

No.

### Other information:

This should be reverted when @sebastienlanglois's changes are in the
`main` branch.
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zeitsperre Zeitsperre mentioned this pull request Feb 29, 2024
5 tasks
@Zeitsperre Zeitsperre merged commit b5aad2b into main Feb 29, 2024
23 checks passed
@Zeitsperre Zeitsperre deleted the update-cookiecutter branch February 29, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants