removes _fix_dates #233
Open
removes _fix_dates #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
for more information, see https://pre-commit.ci
RondeauG
reviewed
Nov 25, 2024
Comment on lines
-599
to
-604
| def _fix_dates(d: dict): | ||
| """Convert dates to the formatting required by HYDROTEL.""" | ||
| # Reformat dates | ||
| for key in ["DATE DEBUT", "DATE FIN"]: | ||
| if len(d.get(key, "")) > 0: | ||
| d[key] = pd.to_datetime(d[key]).strftime("%Y-%m-%d %H:%M") |
There was a problem hiding this comment.
Il faut garder cette partie. C'est LECTURE/ECRITURE seulement qu'on veut enlever.
| simulation_config = deepcopy(_fix_os_paths(_fix_dates(simulation_config))) | ||
| simulation_config = deepcopy(_fix_os_paths(simulation_config)) |
There was a problem hiding this comment.
En lien avec l'autre commentaire, cet appel demeure correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information: