-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update appleSk2.ts #2608
Update appleSk2.ts #2608
Conversation
fixed issue for #2607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you kindly check on the CI failing?
Yes, I have checked the code changes and it solved the problem I encountered very well. However, the manifest shows that I only changed one JS code and the CI failure occurred in the swift code, which is beyond my knowledge. I would be very grateful if I could get some help from you. |
I think it's just because of swift linter, install this on your Mac - https://github.com/realm/SwiftLint and run |
@cervebar It was you who helped me take the first step in swift, thank you very much! |
Any update on this? thanks! |
I'm also looking forward to merging the code. @hyochan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fixed issue for hyochan#2607 hyochan#2461
fixed issue for #2607 #2461