Ability to disable amazon's DRM #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantinosKoulaxizis
added
🤖 android
hyochan
requested changes
Sep 21, 2024
| @@ -19,7 +19,8 @@ android { | |||
| targetSdkVersion rootProject.ext.targetSdkVersion | |||
| versionCode 34 | |||
| versionName "1.16.2" | |||
| buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()`; | |||
| buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString() | |||
| buildConfigField "boolean", "ENABLE_AMAZON_DRM", getExtOrDefault("enableAmazonDrm")`; | |||
There was a problem hiding this comment.
Could we make this look more like a boolean? Something like isAmazonDrmEnabled would be great.
|
Additionally, providing documentation related to this feature would be great |
KonstantinosKoulaxizis
added
the
📖 documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, users want to manage the DRM with their own solution and not use Amazon's DRM. In the past, this was possible by unchecking the DRM option from Amazon's Developer console, but now you can only do it from their SDK.
The
react-native-iapmodule by default will enable Amazon's DRM, but if a user doesn't want to leverage it, there is no option to disable it.With this PR a user can easily disable it by adding
isAmazonDrmEnabled=falseto their gradle.properties file.The default will be
true