Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify integrity of the downloaded content #534

Open
mensfeld opened this issue Oct 10, 2022 · 0 comments
Open

Verify integrity of the downloaded content #534

mensfeld opened this issue Oct 10, 2022 · 0 comments

Comments

@mensfeld
Copy link

Hey,

My name is Maciej Mensfeld, and I do supply chain security research at Mend.io.

I've noticed, that this library downloads external binaries and uses them. While it's a common pattern, integrity verification is lacking here.

This is described as CWE-494.

You could verify the integrity of the downloaded file before using it by comparing the file hash to a hardcoded, expected file hash.

This is essentially what package managers do to verify the integrity of downloaded packages.

Doing this would prevent attack scenarios in which the binaries downloaded here are manipulated.

If the verification happens elsewhere sorry in advance and I would love it if you could point me to the location, so I can tune up my scanning engine.

Have a great day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant