Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): bigint input as string to prevent 000..000 masking #13

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bitbeckers
Copy link
Contributor

  • Input claimIDs as strings in supabase-js because bigint got parsed as number resulting in 340282366920938460000000000000000000000 instead of 340282366920938463463374607431768211456

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 53.93% (🎯 60%) 802 / 1487
🔴 Statements 53.93% (🎯 60%) 802 / 1487
🔴 Functions 54.05% (🎯 60%) 20 / 37
🔴 Branches 50.94% (🎯 60%) 27 / 53
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/indexer/indexClaimsStored.ts 43.24% 33.33% 100% 43.24% 33-74
src/storage/storeHypercerts.ts 39.68% 100% 0% 39.68% 26-63
src/utils/getDeployment.ts 78.37% 33.33% 100% 78.37% 19-25, 35
Generated in workflow #11

@bitbeckers bitbeckers merged commit 02c12d3 into develop Mar 11, 2024
1 check failed
@bitbeckers bitbeckers deleted the fix/claim_id_store branch April 10, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant