Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/metadata properties parsing #240

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

bitbeckers
Copy link
Contributor

  • Logs issues when the parsing of the metadata fails
  • Allow for more flexible metadata.properties field

The current parsing was to strict and rejected valid metadata sets. The
schema was updated to allow any data and allow for a partial properties
object since all fields are optional
Updated the URI event parser to log all issues on errors
@bitbeckers bitbeckers added bug Something isn't working enhancement New feature or request labels Jan 3, 2025
@bitbeckers bitbeckers self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 21.93% (🎯 20%) 1329 / 6060
🟢 Statements 21.93% (🎯 21%) 1329 / 6060
🟢 Functions 58.69% (🎯 58%) 27 / 46
🟢 Branches 44.6% (🎯 44%) 62 / 139
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/parsing/parseUriEvent.ts 93.66% 94.11% 100% 93.66% 66-74
src/utils/metadata.zod.ts 100% 100% 100% 100%
Generated in workflow #193 for commit 5f1d93d by the Vitest Coverage Report Action

@bitbeckers bitbeckers merged commit cf80f0c into develop Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant