-
Notifications
You must be signed in to change notification settings - Fork 388
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add validator operator aliases to default multisig config (#4896)
### Description feat: add validator operator aliases to default multisig config tldr: updated this type and anywhere it's been used ![image](https://github.com/user-attachments/assets/ab055c4f-2fef-4513-a0ff-c574021859c8) - updates `MultisigConfig.validators` type from Address[] to ValidatorConfig[] - `ValidatorConfig` includes both an address + an alias, to be able to track the operator aliases in-code - update any usage of `defaultMultisigConfigs` and `MultisigConfig` type - add `multisigConfigToIsmConfig` helper method to easily convert to `MultisigIsmConfig` format (ie. no aliases) this will simplify the logic in #4774, and enable us to auto-generate the default ISMs docs page after an SDK update ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing - added extra tests to ensure address/aliases are somewhat sound - `yarn tsx scripts/check/check-validator-announce.ts -e mainnet3` still looks good --------- Signed-off-by: pbio <[email protected]>
- Loading branch information
1 parent
e32ee59
commit 4b35374
Showing
16 changed files
with
1,275 additions
and
457 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@hyperlane-xyz/cli': minor | ||
'@hyperlane-xyz/sdk': minor | ||
--- | ||
|
||
Changed the type of defaultMultisigConfigs, to track validator aliases in addition to their addresses. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.