Streamline Rust Agent Config Shapes #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3-agents-rebase #2659 +/- ##
===================================================
Coverage ? 64.16%
===================================================
Files ? 92
Lines ? 1398
Branches ? 186
===================================================
Hits ? 897
Misses ? 494
Partials ? 7 ☔ View full report in Codecov by Sentry. |
# Conflicts: # typescript/sdk/src/index.ts # typescript/sdk/src/metadata/agentConfig.ts # typescript/sdk/src/metadata/chainMetadataTypes.ts # typescript/sdk/src/metadata/deploymentArtifacts.ts # typescript/sdk/src/metadata/matchingList.ts
mattiekat
requested review from
tkporter,
nambrot,
yorhodes,
jmrossy,
aroralanuk and
daniel-savu
as code owners
mattiekat
changed the title
# Conflicts: # rust/agents/relayer/src/settings/matching_list.rs
|
@tkporter for review |
daniel-savu
reviewed
Sep 12, 2023
daniel-savu
approved these changes
Sep 12, 2023
…nfig/head # Conflicts: # typescript/token/tsconfig.json
yorhodes
added a commit
that referenced
this pull request
Oct 3, 2023
Continues the updates to the rust config shapes by updating deployment and runtime expectations. This PR also attempts to rely on the new single source of truth created by the schema in the SDK as much as reasonably possible which helped delete more code but also give some guarantees of consistency. THIS IS A BREAKING CHANGE! It changes the config shapes the agents want and we should not merge this until we are ready. Fixes #2215 --------- Co-authored-by: Guillaume Bouvignies <[email protected]> Co-authored-by: Yorke Rhodes <[email protected]> Co-authored-by: Guillaume Bouvignies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continues the updates to the rust config shapes by updating deployment and runtime expectations. This PR also attempts to rely on the new single source of truth created by the schema in the SDK as much as reasonably possible which helped delete more code but also give some guarantees of consistency.
THIS IS A BREAKING CHANGE! It changes the config shapes the agents want and we should not merge this until we are ready.
Fixes #2215