Prevent invalid destination griefing for the relayer #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description - Adding Optimism Hook for MailboxV3 ### Drive-by changes - dispatch function with hookMetadata ### Related issues - hyperlane-xyz/issues#513 ### Backward compatibility No ### Testing None
#2609) Co-authored-by: Kunal Arora <[email protected]>
### Description - IGP as a standalone hook, implementing postDispatch to call payForGas directly - Setting a DEFAULT_GAS_USAGE if metadata not specified and message.senderAddress() as refund address if not specified. ### Drive-by changes - None ### Related issues Fixes hyperlane-xyz/issues#511 ### Backward compatibility Yes, same interface as the previous IGP but for Mailbox V3 ### Testing Unit Tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
### Description - Updated the OP Stack tests for the Mailbox V3 transient storage version - Allowing OPStackHook to send msg.value at the time of message delivery (uses bit masking) - Added LibBit library, will be useful for all the auth hooks which can send `msg.value` ### Drive-by changes - None ### Related issues - Fixes breaking OP Stack tests for hyperlane-xyz/issues#513 - Also fixes #2410 ### Backward compatibility No ### Testing Unit tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
### Description - Adding protocol fee as a hook ### Drive-by changes - None ### Related issues V3 ### Backward compatibility Yes ### Testing Fuzz tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
### Description - fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes ### Drive-by changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main ### Related issues - V3 ### Backward compatibility Yes ### Testing Unit tests
### Description
- `quoteDispatch` added to `IPostDispatchHook` interface and the
relevant hooks:
- StaticProtocolFee
- OPStackHook
- InterchainGasPaymaster
- MerkleTreeHook
- PausableHook (no tests)
- DomainRoutingHook (no tests)
- ConfigFallbackDomainRoutingHook
- ConfigurableDomainRoutingHook (no tests)
### Drive-by changes
- `expectEmit` -> `expectCall`
### Related issues
- Quote in V3
### Backward compatibility
Yes
### Testing
Uint tests
### Description - AggregationHook for v3 ### Drive-by changes None ### Related issues v3 hyperlane-xyz/issues#514 ### Backward compatibility Yes ### Testing Always be fuzzing
aroralanuk
requested review from
mattiekat,
tkporter,
asaj and
yorhodes
as code owners
Signed-off-by: -f <[email protected]>
tkporter
requested changes
Sep 7, 2023
### Description - V3 compatible ERC20, ERC721 and all their extensions ### Drive-by changes - Painstakingly migrating hardhat tests to foundry tests for all variants ### Related issues - fixes hyperlane-xyz/issues#577 ### Backward compatibility Yes ### Testing whole lotta unit tests and poor man's version of integration tests --------- Signed-off-by: -f <[email protected]> Co-authored-by: Yorke Rhodes <[email protected]>
aroralanuk
requested review from
jmrossy,
Skunkchain,
nambrot and
avious00
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3 #2703 +/- ##
=======================================
Coverage 49.32% 49.32%
=======================================
Files 107 107
Lines 1417 1417
Branches 179 179
=======================================
Hits 699 699
Misses 711 711
Partials 7 7
☔ View full report in Codecov by Sentry. |
|
Issues right now:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GasPaymenteventdestinationwhile reading events for the relayerDrive-by changes
Related issues
Backward compatibility
No, change in event emitted and relayer indexing
Testing