-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sealevel): read / write igp gas oracle config #2705
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
=======================================
Coverage 64.50% 64.50%
=======================================
Files 91 91
Lines 1386 1386
Branches 185 185
=======================================
Hits 894 894
Misses 485 485
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if there's a way to make the read vs write thing more explicit, maybe something like --write
needs to be passed in or something? Idk, just would be nice to make it really hard to accidentally misuse it
came up with this ( # get
cargo run --bin hyperlane-sealevel-client igp destination-gas-overhead --environments-dir ./sealevel/environments --environment mainnet2 --chain-name solana --remote-domain 56 get
# set
cargo run --bin hyperlane-sealevel-client igp destination-gas-overhead --environments-dir ./sealevel/environments --environment mainnet2 --chain-name solana --remote-domain 56 set --gas-overhead 159736 |
Description
Tooling to get / set gas oracle data for sealevel, part of https://github.com/hyperlane-xyz/issues/issues/568
The PR adds two IGP oracle commands. If the values to be set are specified, then the command performs a write using the key configured. Otherwise, it performs a read. Unsure whether this is the best UX, happy to change it.
Usage example:
There's also a small warp route util added to read the destination gas:
Drive-by changes
Related issues
Backward compatibility
Testing
Manual